[Discover] Unskip date_nanos and shard links functional tests #82878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
changed the title
This was referenced Nov 9, 2020
kertal
commented
Nov 10, 2020
src/plugins/data/common/index_patterns/index_patterns/index_patterns.ts
Outdated
Show resolved
Hide resolved
kertal
commented
Nov 10, 2020
src/plugins/data/common/index_patterns/index_patterns/index_patterns.ts
Outdated
Show resolved
Hide resolved
kertal
commented
Nov 11, 2020
src/plugins/data/public/index_patterns/index_patterns/index_patterns_api_client.ts
Outdated
Show resolved
Hide resolved
kertal
commented
Nov 11, 2020
src/plugins/data/common/index_patterns/index_patterns/index_patterns.ts
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
5 tasks
…-06-discover-unskip-date-nanos
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kertal
changed the title
kertal
added
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
majagrubic
approved these changes
Nov 30, 2020
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Nov 30, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 30, 2020
* master: (25 commits) [Alerting] fixes buggy default message behaviour (elastic#84202) [Graph] Use new ES client and change license API (elastic#84398) [DOCS] Adds redirect to known plugins page (elastic#84001) Update IndexPatternSelect to get fields from indexPatternService instead of savedObject attributes (elastic#84376) Adding timestamps to created events so the sorting is stable (elastic#84515) [DOCS] Redirects for drilldown links (elastic#83846) [Fleet] Support for showing an Integration Detail Custom (UI Extension) tab (elastic#83805) [Enterprise Search] Migrate shared Schema components (elastic#84381) [Discover] Unskip date_nanos and shard links functional tests (elastic#82878) [APM] ML anomaly detection integration: Displaying anomaly job results in the Transaction duration chart is not as intended (elastic#84415) Support for painless language autocomplete within monaco (elastic#80577) [Lens] Time scale ui (elastic#83904) removing beta callouts (elastic#84510) [Lens] (Accessibility) add aria-label to chart type icon (elastic#84493) Trusted Apps signer API. (elastic#83661) increase stdout max listeners for legacy logging (elastic#84497) [APM] Service overview: Add throughput chart (elastic#84439) [Discover] Unskip main functional tests (elastic#84300) Uptime overview overhaul (elastic#83406) [APM] Adjust time formats based on the difference between start and end (elastic#84470) ...
kertal
added a commit
that referenced
this pull request
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR originally used for investigation of #81457 adding logs for flaky test runner . However in the meantime lot's of the underlying index pattern API changed, so the failure that originally led to the skipping of this tests is no longer possible. So what this PR just takes care of the unskipping. And here are 150 flaky test runner runs to prove that there's no flakiness involved:
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1030/
Fixes #82035
Fixes #80104
Checklist
Delete any items that are not applicable to this PR.
For maintainers